Increased TSM-buffer size to 16 MiB #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TSM-buffer size was increased to 16 MiB. As a consquence of this the TSM buffer has to be allocated on the heap for ltsmc.c and common.c to prevent segmentation faults.
ChristianTackeGSI
approved these changes
Oct 23, 2025
Member
ChristianTackeGSI
left a comment
ChristianTackeGSI
left a comment
There was a problem hiding this comment.
Looks good for now. :-)
I assume this was tested somewhat?
Comment on lines
+184
to
+190
| int rc_minor; | ||
|
|
||
| rc_minor = fclose(file); | ||
| if (rc_minor) { | ||
| rc_minor = -errno; | ||
| CT_ERROR(rc_minor, "fclose failed on '%s'", filename); | ||
| if (buf) free(buf); |
Member
There was a problem hiding this comment.
Maybe move the if (buf) free(buf); above the int rc_minor;?
Something like this?
if (buf) free(buf);
buf = NULL;
int rc_minor = fclose(file);
Member
There was a problem hiding this comment.
Concerns were raised in private that this could clobber some return values / errno. I appreciate the thoughtfulness about errno preservation in general.
Well.
-
The free() function returns no value, and preserves errno.
(from "man 3 free" on my Linux System)
If anyone has a reference to an implementation or documentation indicating that
free()can modify errno, please share it. -
The
free()is just below the while loop.- What errno should it clobber there? By
feof()? Well according to my manpages, it does not set errno either. - The
fclose()(where we want to preserveerrno!) is just below thefree().
- What errno should it clobber there? By
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TSM-buffer size was increased to 16 MiB. As a consquence of this the TSM buffer has to be allocated on the heap for ltsmc.c and common.c to prevent segmentation faults.